updates on ci to apply best practices and split jobs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI/CD pipeline by implementing security best practices and improving job organization. The changes focus on pinning actions to specific commit hashes instead of tags and separating linting concerns into a dedicated workflow.
- Pin GitHub Actions to specific commit hashes for enhanced security
- Create a dedicated golangci-lint workflow for better separation of concerns
- Update Go version and apply formatting improvements to YAML structure
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/golangci-lint.yml |
New dedicated workflow for Go linting with pinned action versions |
.github/workflows/ci.yml |
Updated main CI workflow with pinned actions and Go version bump |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Carlos Panato <[email protected]>
tstromberg
requested changes
Aug 13, 2025
Member
tstromberg
left a comment
tstromberg
left a comment
There was a problem hiding this comment.
Looks good overall - just one nit about golangci-lint.
Signed-off-by: Carlos Panato <[email protected]>
tstromberg
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.